Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Az.ServiceBus Syntax Errors #17782

Merged
merged 2 commits into from
May 6, 2022
Merged

Fix Az.ServiceBus Syntax Errors #17782

merged 2 commits into from
May 6, 2022

Conversation

v-yuzhichen
Copy link
Contributor

Description

Checklist

  • I have read the Submitting Changes section of CONTRIBUTING.md
  • The title of the PR is clear and informative
  • The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • The PR does not introduce breaking changes
  • If applicable, the changes made in the PR have proper test coverage
  • For public API changes to cmdlets:
    • a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
      • {Please put the link here}
    • the markdown help files have been regenerated using the commands listed here

@v-yuzhichen v-yuzhichen requested a review from ziyuezh576 April 12, 2022 13:57
ziyuezh576
ziyuezh576 suggested changes Apr 18, 2022
View reviewed changes
src/ServiceBus/ServiceBus/help/Add-AzServiceBusVirtualNetworkRule.md
@@ -33,7 +33,7 @@ Add a single VirtualNetworkRule to NetworkRuleSet for the given Namespace

### Example 1
```powershell
Add-AzServiceBusVirtualNetworkRule -ResourceGroupName v-ajnavtest -Namespace ServiceBus-Namespace1-2389 -SubnetId "/subscriptions/SubscriptionId/resourcegroups/ResourceGroup/v-ajnavtest/providers/Microsoft.Network/virtualNetworks/sbehvnettest1/subnets/sbdefault01" -IgnoreMissingVnetServiceEndpoint
Add-AzServiceBusVirtualNetworkRule -ResourceGroupName v-ajnavtest -Name ServiceBus-Namespace1-2389 -SubnetId "/subscriptions/SubscriptionId/resourcegroups/ResourceGroup/v-ajnavtest/providers/Microsoft.Network/virtualNetworks/sbehvnettest1/subnets/sbdefault01" -IgnoreMissingVnetServiceEndpoint
```
Name : default
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

output

src/ServiceBus/ServiceBus/help/Add-AzServiceBusIPRule.md
@@ -32,7 +32,7 @@ Add a single IP rule to the NetworkRuleSet of the given Namespace

### Example 1
```powershell
Add-AzServiceBusIPRule -ResourceGroupName v-ajnavtest -Namespace ServiceBus-Namespace1-2389 -IpMask "11.22.33.44" -Action Allow
Add-AzServiceBusIPRule -ResourceGroupName v-ajnavtest -Name ServiceBus-Namespace1-2389 -IpMask "11.22.33.44" -Action Allow
```
Name : default
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

output

src/ServiceBus/ServiceBus/help/Add-AzServiceBusIPRule.md
@@ -45,7 +45,7 @@ add the IPRule with IpMask "11.22.33.44" and Action Allow fro the given namespac

### Example 2
```powershell
Add-AzServiceBusIPRule -ResourceGroupName v-ajnavtest -Namespace ServiceBus-Namespace1-2389 -IpRuleObject $ipruleObject
Add-AzServiceBusIPRule -ResourceGroupName v-ajnavtest -Name ServiceBus-Namespace1-2389 -IpRuleObject $ipruleObject
```
Name : default
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

output

src/ServiceBus/ServiceBus/help/Add-AzServiceBusVirtualNetworkRule.md
@@ -46,7 +46,7 @@ Adds the given Subnet and IgnoreMissingVnetServiceEndpoint (VirtualNetworkRule)

### Example 2
```powershell
Add-AzServiceBusVirtualNetworkRule -ResourceGroupName v-ajnavtest -Namespace ServiceBus-Namespace1-2389 -VirtualNetworkRuleObject $virtualruleset1
Add-AzServiceBusVirtualNetworkRule -ResourceGroupName v-ajnavtest -Name ServiceBus-Namespace1-2389 -VirtualNetworkRuleObject $virtualruleset1
```
Name : default
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

output

src/ServiceBus/ServiceBus/help/Set-AzServiceBusAuthorizationRule.md Outdated
@@ -47,33 +47,33 @@ The **Set-AzServiceBusAuthorizationRule** cmdlet updates the description for the

### Example 1
```powershell
$authRuleObj = Get-AzServiceBusNamespaceAuthorizationRule -ResourceGroup Default-ServiceBus-WestUS -Namespace SB-Example1 -Name AuthoRule1
$authRuleObj = Get-AzServiceBusAuthorizationRule -ResourceGroup Default-ServiceBus-WestUS -Namespace SB-Example1 -Name AuthoRule1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-ResourceGroup → -ResourceGroupName

src/ServiceBus/ServiceBus/help/Set-AzServiceBusAuthorizationRule.md Outdated
```

Removes **Manage** from the access rights of the authorization rule `AuthoRule1` in namespace `SB-Example1`.

### Example 2
```powershell
$authRuleObj = Get-AzServiceBusNamespaceAuthorizationRule -ResourceGroup Default-ServiceBus-WestUS -Namespace SB-Example1 -Queue SBQueue -Name AuthoRule1
$authRuleObj = Get-AzServiceBusAuthorizationRule -ResourceGroup Default-ServiceBus-WestUS -Namespace SB-Example1 -Queue SBQueue -Name AuthoRule1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-ResourceGroup → -ResourceGroupName

src/ServiceBus/ServiceBus/help/Set-AzServiceBusAuthorizationRule.md Outdated

$authRuleObj.Rights.Remove("Manage")

Set-AzServiceBusNamespaceAuthorizationRule -ResourceGroup Default-ServiceBus-WestUS -Namespace SB-Example1 -Queue SBQueue -Name AuthoRule1 -InputObj $authRuleObj
Set-AzServiceBusAuthorizationRule -ResourceGroup Default-ServiceBus-WestUS -Namespace SB-Example1 -Queue SBQueue -Name AuthoRule1 -InputObj $authRuleObj
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-ResourceGroup → -ResourceGroupName

src/ServiceBus/ServiceBus/help/Set-AzServiceBusAuthorizationRule.md Outdated
```

Removes **Manage** from the access rights of the authorization rule `AuthoRule1` in queue `SBQueue`.

### Example 3
```powershell
$authRuleObj = Get-AzServiceBusNamespaceAuthorizationRule -ResourceGroup Default-ServiceBus-WestUS -Namespace SB-Example1 -Topic SBTopic -Name AuthoRule1
$authRuleObj = Get-AzServiceBusAuthorizationRule -ResourceGroup Default-ServiceBus-WestUS -Namespace SB-Example1 -Topic SBTopic -Name AuthoRule1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-ResourceGroup → -ResourceGroupName

src/ServiceBus/ServiceBus/help/Set-AzServiceBusAuthorizationRule.md Outdated

$authRuleObj.Rights.Remove("Manage")

Set-AzServiceBusNamespaceAuthorizationRule -ResourceGroup Default-ServiceBus-WestUS -Namespace SB-Example1 -Topic SBTopic -Name AuthoRule1 -InputObj $authRuleObj
Set-AzServiceBusAuthorizationRule -ResourceGroup Default-ServiceBus-WestUS -Namespace SB-Example1 -Topic SBTopic -Name AuthoRule1 -InputObj $authRuleObj
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-ResourceGroup → -ResourceGroupName

src/ServiceBus/ServiceBus/help/Set-AzServiceBusNetworkRuleSet.md Outdated
@@ -57,7 +57,7 @@ Update the NetworkRuleSet using -IPRule and -VirtualNetworkRule parameters

### Example 2
```powershell
$getresult = Get-AzServiceBusNetworkRuleSet -ResourceGroupName v-ajnavtest -Namespace ServiceBus-Namespace1-1375
$getresult = Get-AzServiceBusNetworkRuleSet -ResourceGroupName v-ajnavtest -Name ServiceBus-Namespace1-1375
Set-AzServiceBusNetworkRuleSet -ResourceGroupName v-ajnavtest -Namespace ServiceBus-Namespace1-1375 -InputObject $getresult
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-Namespace → -Name

@wyunchi-ms wyunchi-ms merged commit 7457dae into Azure:main May 6, 2022
@isra-fel isra-fel mentioned this pull request May 26, 2022
Closed
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ziyuezh576 ziyuezh576 ziyuezh576 approved these changes

Assignees

@ziyuezh576 ziyuezh576

Labels
Doc - Reference needs-review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@v-yuzhichen @ziyuezh576 @wyunchi-ms